Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto for variable type for results of cast operations #60938

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nyalldawson
Copy link
Collaborator

@nyalldawson nyalldawson added the Cleanup Code cleanup label Mar 10, 2025
@github-actions github-actions bot added this to the 3.44.0 milestone Mar 10, 2025
Copy link

github-actions bot commented Mar 11, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 311085f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 311085f)

@uclaros
Copy link
Contributor

uclaros commented Mar 11, 2025

I'm a little skeptical about this (same with #60502, but too late!).
I perceive Relaxing the prohibition more like it's now ok to use, rather than replace every occurrence of.

Only updates:

- pointers and complex types
- types with length > 12
@nyalldawson
Copy link
Collaborator Author

@uclaros ok, i've reworked the script so it ONLY updates pointer or complex types and ignores those with length <= 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants