[3D] Fix some issues in 3D point cloud editing tools #60917
+66
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes msvc build issue caused by uniqueqobject pointer, we revert back to raw pointers. Fixes QGIS crash on 3D window closed when editing tools are selected. We can't delete QgsRubberBand3D entities from this class as they are owned by RubberBandRootEntity, which deletes them on windows close. Only point rubberbands leave artifacts in scene whene deleted by default destructor.
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
uclaros
reviewed
Mar 10, 2025
Comment on lines
+172
to
+173
| if ( mScreenPoints.size() != 2 ) | ||
| return; |
There was a problem hiding this comment.
Should we not support above/below lines with more than 2 points?
I'd move the
if ( mScreenPoints.size() < 3 )
return;guard at the top of the run method.
There was a problem hiding this comment.
Should we not support above/below lines with more than 2 points?
After discussion with @wonder-sk we decided that we will support just 2 points, not more.
I'd move the
if ( mScreenPoints.size() < 3 ) return;guard at the top of the run method.
The thing is we add the screen edges points when using line tool right before that guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some new issues found while using point cloud editing tools.
SPACE