[mssql] Add workaround for incorrect geometry system type returned by sp_describe_first_result_set #60909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sp_describe_first_result_set Some (versions?) (setups?) of SQL server incorrectly report that the system type for a geometry columns is "image" in their sp_describe_first_result_set results. Let's just automatically override this and set it back to "geometry" if we know that the column is actually the geometry column. Fixes broken query layers on these databases
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
alexbruy
approved these changes
Mar 10, 2025
|
I have tested this fix and can confirm it works. Spatial features now show up as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some (versions?) (setups?) of SQL server incorrectly report that the system type for a geometry columns is "image" in their sp_describe_first_result_set results.
Let's just automatically override this and set it back to "geometry" if we know that the column is actually the geometry column.
Fixes broken query layers on these databases
** THIS IS IMPOSSIBLE TO UNIT TEST **