Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crashing when a tiled scene texture is provided by an extension #60880

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Mar 6, 2025

Description

Handle the case when texture.source is undefined, because the texture is provided by an extension, eg. EXT_texture_webp

According to spec:

When texture.source is undefined, the image SHOULD be provided by an extension or application-specific means, otherwise the texture object is undefined.

fixes: #57024

@uclaros uclaros added Bug Either a bug report, or a bug fix. Let's hope for the latter! Tiled Scene Related to tiled scene layers backport release-3_40 backport release-3_42 labels Mar 6, 2025
@github-actions github-actions bot added this to the 3.44.0 milestone Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 6adcb71)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 6adcb71)

@uclaros uclaros closed this Mar 7, 2025
@uclaros uclaros reopened this Mar 7, 2025
@nyalldawson nyalldawson reopened this Mar 10, 2025
@uclaros uclaros closed this Mar 10, 2025
@uclaros uclaros reopened this Mar 10, 2025
@nyalldawson nyalldawson merged commit 2739454 into qgis:master Mar 10, 2025
147 of 157 checks passed
@uclaros uclaros deleted the fix-scene-webp branch March 10, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-3_40 backport release-3_42 Bug Either a bug report, or a bug fix. Let's hope for the latter! Tiled Scene Related to tiled scene layers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3D Tiles dataset crashes 3D map view
3 participants