[LegendUrl] Make legend url part of server properties #60863
+191
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
|
unrelated test failure |
nyalldawson
reviewed
Mar 11, 2025
src/core/qgsmaplayer.cpp
Outdated
|
|
||
| void QgsMapLayer::setLegendUrl( const QString &legendUrl ) | ||
| { | ||
| QGIS_PROTECT_QOBJECT_THREAD_ACCESS_NON_FATAL |
There was a problem hiding this comment.
Can we upgrade this to the FATAL error? Or does that break existing tests?
There was a problem hiding this comment.
Done. Let's see if it breaks anything
There was a problem hiding this comment.
Besides the grass issue, there is a Hana test failing but I don't think it's related at all to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legend Url and legend Url format should be part of server properties. There are edited whitin QGIS Server tab parameters and are only used in WMS GetCapabilities.
I'm planning to refactor then those settings editing to remove duplicate code.
Funded by Ifremer