Allow free naming of project properties #60855
Open
+57
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
jef-n
force-pushed
the
arbitrary-property-names
branch
from
81b0ae9 to
90d927b
Compare
Allows:
<properties name="properties">
<properties name="1">
<properties name="2" type="QString">foo</properties>
</properties>
</properties>
Data-driven properties names could violate that monstrous regular
expression earlier (eg. using layer ids with leading digits as key was
illegal) and trigger "Entry token invalid" for no too obvious reason
(even when trying to remove a non-existing entry).
Turns
<properties>
<foo>
<bar type="QString">baz</bar>
</foo>
</properties>
into
<properties name="properties">
<properties name="foo">
<properties name="bar" type="QString">baz</properties>
</properties>
</properties>
jef-n
force-pushed
the
arbitrary-property-names
branch
from
90d927b to
8f84b3c
Compare
|
@jef-n , sorry, I read this way too quickly, I was referring to this XML cleanup on project load: https://github.com/qgis/QGIS/pull/55041/files#diff-911caa2767015e8dc9678b56bebaa47c7852167695ec49e048ad2f384cb6e391R1847 Ignore me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows:
Data-driven properties names could violate that monstrous regular expression earlier (eg. using layer ids with leading digits as key was illegal) and trigger "Entry token invalid" for no too obvious reason (even when trying to remove a non-existing entry).
Turns
into