Correctly move layout legend nodes when they are filtered #60536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
I don't see why clang-tidy fails here... locally I don't get the moc file missing error, only the warnings. By the way, I did not change anything in the includes. |
Djedouas
force-pushed
the
composer-filtered-legend
branch
2 times, most recently
from
5efa4c6 to
a3bebfc
Compare
|
#60592 Should fix the cland-tidy issue but it's not related at all to this PR |
Djedouas
force-pushed
the
composer-filtered-legend
branch
from
a3bebfc to
9da1bef
Compare
nyalldawson
added
backport queued_ltr_backports
Djedouas
force-pushed
the
composer-filtered-legend
branch
from
9da1bef to
89f77b1
Compare
|
You have to fix the warning in clang-tidy, an anonymous namespace may fix it |
Djedouas
force-pushed
the
composer-filtered-legend
branch
from
6ad1436 to
874685d
Compare
troopa81
reviewed
Mar 6, 2025
Djedouas
force-pushed
the
composer-filtered-legend
branch
from
874685d to
82098b4
Compare
troopa81
reviewed
Mar 6, 2025
Djedouas
force-pushed
the
composer-filtered-legend
branch
from
82098b4 to
59e41c0
Compare
…ltered Fixes qgis#60383. In a layout, when moving a legend node on a filtered legend, the computed offset was wrong if some nodes were hidden between the node to move and its destination. The offset is now computed with the next/previous visible index.
For "private" functions like the underscore-prefixed-by-convention functions, use an unnamed namespace to affect visibility over static keyword which has many meanings.
Djedouas
force-pushed
the
composer-filtered-legend
branch
from
59e41c0 to
6f32786
Compare
|
unrelated test failure |
This was referenced Mar 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #60383.
In a layout, when moving a legend node on a filtered legend, the computed offset was wrong if some nodes were hidden between the node to move and its destination.
The offset is now computed with the next/previous visible index.