Update pull request merge criteria to point to QEP 323 #9699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelazJ
reviewed
Mar 4, 2025
DelazJ
reviewed
Mar 4, 2025
| fixes, translation string fixes, tab order changes, or similar. | ||
|
|
||
| Please see [QEP 323 - Change submission and merge policies](https://github.com/qgis/QGIS-Enhancement-Proposals/blob/master/qep-323-code-submission-policy.md) | ||
| for the current policies regarding acceptable pull request submission. |
There was a problem hiding this comment.
Is it for PR submission or PR merging?
There was a problem hiding this comment.
Well, there's no point submitting if it's inappropriate to merge. That just makes more work 😅
|
@nyalldawson May be the https://github.com/qgis/QGIS/blob/master/CONTRIBUTING.md should be adapted accordingly? |
benoitdm-oslandia
approved these changes
Mar 4, 2025
DelazJ
added
the
backport release_3.40
DelazJ
added a commit
that referenced
this pull request
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QEP 323 is now the definitive, dynamic source for these policies