Field properties (comments and alias) update #8795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelazJ
added
the
backport release_3.34
DelazJ
reviewed
Feb 2, 2024
| @@ -2068,7 +2068,7 @@ fields related to the layer and helps you organize them. | |||
| The layer can be made :ref:`editable <editingvector>` using the |toggleEditing| | |||
| :sup:`Toggle editing mode`. At this moment, you can modify its structure using | |||
| the |newAttribute| :sup:`New field` and |deleteAttribute| :sup:`Delete field` | |||
| buttons. | |||
| buttons. | |||
There was a problem hiding this comment.
Suggested change
| buttons. | |
| buttons. |
| @@ -2077,7 +2077,8 @@ depending on the GDAL version. | |||
| If set in the underlying data source or in the :ref:`forms properties | |||
| <configure_field>`, the field's alias is also displayed. An alias is a human | |||
| readable field name you can use in the feature form or the attribute table. | |||
| Aliases are saved in the project file. | |||
| Aliases are saved in the project file. Currently supported for OGR formats | |||
| with field comment capabilities such as GeoPackage or ESRI File Geodatabase. | |||
There was a problem hiding this comment.
I think a feature here is that you now have a "comment" box (along with alias) you can fill when creating a field for a layer that supports it. Below, a gpkg.
Btw, why are the lists of formats different? should we not have the same list as in lines 2096-97?
There was a problem hiding this comment.
I added new explanation, hope this is more clarified. I used information from changelog.
DelazJ
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8166