-
-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style database update added #8765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@selmaVH1 I miss what a project style db is and why and how it could be used. Also the reported issue concerns a lot the style manager chapter, which doesn't appear in your changes.
Can you give it a deeper look please? Thanks.
@@ -510,6 +510,9 @@ From a drop-down list of current layers in the layer panel, select an item and: | |||
layer style in the current project: you can therefore cancel or restore to any | |||
state by selecting it in the list and clicking :guilabel:`Apply`. | |||
|
|||
In the :guilabel:`Layer Styling` panel you can also choose to press the | |||
:guilabel:`Save Symbol` button to add the symbol being edited to the :ref:`style_database`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see such a button as part of the Layer styling panel. The "Save symbol" is an element of symbol properties (so available wherever you edit a symbol), mentioned at https://docs.qgis.org/3.34/en/docs/user_manual/style_library/symbol_selector.html#configuring-a-symbol. And adding the symbol to project style db is one option of the button, not the only one.
Style Database | ||
.............. | ||
|
||
QGIS enables you to link projects to multiple style databases. When project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss a lot of information that are quite well exposed/explained in the issue report and would be worth reused in the docs: what a style database? Why would I want to use it? What types? Where are they stored?
And this issue should necessarily concern also the Style manager chapter on the GUI, the save symbols widget options,...
(reworded)
|
HI @DelazJ I have been thinking about updating the Style Manager section, but I'm having trouble figuring out how to connect the Save button from the layer styling (which has the function of saving symbols to the style database) with the Style Manager. One idea I have is to update or reorganize the first part of the section. Screenshots, from what I can see, need an update as well. Additionally, the drop-down menu should be described at the beginning of the section, along with the "Copy to default style" button, which is currently explained in the "Using the browser panel" section? |
I'm not sure if I get your question but that "save symbol" button is mentioned here without describing the options the dialog proposes (connection with styles databases, not just the library).
I think the screenshot is somehow up to date (the "copy to default style" only appears if you select something different to "default" in top left corner - it depends on what we want to show). We indeed miss explanation on what the top left elements are (the styles databases) and how they affect the displayed list of symbols. Not sure to what extent it implies reorganizing the first part; I would see something here, but feel free. |
@selmaVH1 can you address the remaining comments so that we merge this one also? |
fixes #7568