Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "nested instantiation" #2535

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felipemello1
Copy link
Contributor

Reverts #2519

image

@felipemello1 felipemello1 requested a review from ebsmothers March 28, 2025 22:26
Copy link

pytorch-bot bot commented Mar 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2535

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fc18a65 with merge base 8dadbaa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.55%. Comparing base (f3587e5) to head (fc18a65).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
torchtune/config/_instantiate.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
- Coverage   66.97%   64.55%   -2.42%     
==========================================
  Files         375      375              
  Lines       22295    22259      -36     
==========================================
- Hits        14932    14370     -562     
- Misses       7363     7889     +526     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants