Skip to content

Remove ST from torchsnapshot #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove ST from torchsnapshot #143

wants to merge 1 commit into from

Conversation

fduwjj
Copy link

@fduwjj fduwjj commented May 22, 2023

As part of ShardedTensor deprecation, we start the cleanup for its use case in torch snapshot. This is the first PR for a series PR and want to get feedback from owner and the community to see if this is the right thing to do.

Summary:
As above.

Test plan:
Unit test.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2023
@fduwjj fduwjj requested a review from yifuwang May 22, 2023 23:29
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #143 (496be7c) into main (087caae) will decrease coverage by 41.37%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #143       +/-   ##
===========================================
- Coverage   92.15%   50.78%   -41.37%     
===========================================
  Files          58       58               
  Lines        4408     4405        -3     
===========================================
- Hits         4062     2237     -1825     
- Misses        346     2168     +1822     
Impacted Files Coverage Δ
torchsnapshot/io_preparer.py 67.21% <100.00%> (-29.62%) ⬇️

... and 48 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fduwjj
Copy link
Author

fduwjj commented Jun 1, 2023

Paused this for now and we need to verify with TorchRec on its usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants