Move "scanned" metadata as video-only and add begin_stream_from_header
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
changed the title
begin_stream_from_header
NicolasHug
commented
Mar 24, 2025
| @@ -13,7 +13,7 @@ | |||
| from torchcodec.decoders import _core as core | |||
| from torchcodec.decoders._decoder_utils import ( | |||
| create_decoder, | |||
| get_and_validate_stream_metadata, | |||
| ERROR_REPORTING_INSTRUCTIONS, | |||
There was a problem hiding this comment.
Changes below: we previously had a common util for audio and video that extracted and validated the metadata: get_and_validate_stream_metadata(). Since we moved a bunch of fields as video-only, this util wasn't generic enough anymore to justify its existence, hence a few edits here and in the video_decoder.py file.
scotts
reviewed
Mar 24, 2025
| if (streamMetadata.beginStreamFromHeader.has_value()) { | ||
| map["beginStreamFromHeader"] = | ||
| std::to_string(*streamMetadata.beginStreamFromHeader); | ||
| } |
There was a problem hiding this comment.
This reminded me to create Issue #593.
scotts
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of related things:
begin_stream_seconds_from_headerfield to audio and video metadata. It is derived from the AVStream'sstart_timefield. This field is useful e.g. in our tutorial example because it is now clear that the stream doesn't exactly starts at 0.begin_stream_seconds_from_contentandend_stream_seconds_from_contentfields as video-only: these fields are derived from a scan, so there's no point having them for audio.duration_secondsmetadata as video-only, because it is derived frombegin_stream_seconds_from_contentandend_stream_seconds_from_content. This means that audio metadata now only containsduration_seconds_from_header.start_secondsin the call toget_samples_played_in_range: the input check was based onbegin_stream_seconds_from_contentso that didn't make much sense. We still have tests that make sure we provide good error messages in the incorrect cases.