Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from JSON as metadata interchange between C++ and Python #593

Closed
scotts opened this issue Mar 24, 2025 · 2 comments
Closed

Move away from JSON as metadata interchange between C++ and Python #593

scotts opened this issue Mar 24, 2025 · 2 comments
Labels
good first issue Good for newcomers refactor Improves code itself, but does not fix a bug or add new functionality.

Comments

@scotts
Copy link
Contributor

scotts commented Mar 24, 2025

All of the metadata we expose to users in Python comes from the C++ side. These are mostly fields in the C++ VideoDecoder. Right now, we communicate that data from C++ to Python through a JSON string. We should explore other mechanisms so that we don't rely on JSON on the Python side.
@scotts scotts added good first issue Good for newcomers refactor Improves code itself, but does not fix a bug or add new functionality. labels Mar 24, 2025
@scotts scotts mentioned this issue Mar 24, 2025
Merged
@NicolasHug
Copy link
Member

This might be a duplicate of #97?

@scotts
Copy link
Contributor Author

scotts commented Mar 25, 2025 •
edited
Loading

Definitely is.

@scotts scotts closed this as completed Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Improves code itself, but does not fix a bug or add new functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scotts @NicolasHug