[tritonbench] Add triton compile time dashboard #6513
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| return ( | ||
| <> | ||
| <Grid2 container spacing={2}> | ||
| <Grid2 size={{ xs: 12, lg: 6 }} height={GRAPH_ROW_HEIGHT}> |
There was a problem hiding this comment.
If there is only one chart, you could set lg to 12 to display it in the whole horizontal space instead of half the screen I think
There was a problem hiding this comment.
We will start from one chart and add more subgraphs later, e.g., more workload suites and break-down of the compilation time by stages (e.g., TTIR, TTGIR compile time).
| @@ -0,0 +1,47 @@ | |||
| WITH results AS ( | |||
There was a problem hiding this comment.
As this is a brand new dashboard, it's probably ok to keep these separate queries for flexibility. But I suspect that we can fold them into existing https://github.com/pytorch/test-infra/tree/main/torchci/clickhouse_queries/oss_ci_benchmark_llms. That's for a later PR if needed
cc @yangw-dev
There was a problem hiding this comment.
Right, we are open to converge into the existing queries if that is possible.
Located at
/tritonbench/compile_time.Data source: Tritonbench nightly run: https://github.com/pytorch-labs/tritonbench/actions/workflows/compile-time.yaml
Test plan:
cc @Jokeren