Skip to content

[ET-VK][ez] Make squeeze insertion requirements more strict #9917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions backends/vulkan/_passes/squeeze_unsqueeze_inputs.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,25 +27,38 @@ class SqueezeUnsqueezeInputs(ExportPass):
exir_ops.edge.aten.gelu.default,
}

def should_squeeze(self, op, shape: List[int]) -> bool: # pyre-ignore
if len(shape) == 3:
return shape[1] == 1 and shape[0] > 1
if len(shape) == 4:
# No need to squeeze if all dims are 1 except the width dim
if all(dim == 1 for dim in shape[:-1]):
return False
# Otherwise, check for squeezable dim
return 1 in shape[:-1]

# Prefer not to introduce additional orchestration ops by default
return False

def call_operator(
self,
op, # pyre-ignore
args: Tuple[Argument, ...],
kwargs: Dict[str, Argument],
meta: NodeMetadata,
) -> ProxyValue:
def _squeezable(shape: List[int]) -> bool:
return len(shape) > 2 and 1 in shape

if op not in self._squeezable_ops:
return super().call_operator(op, args, kwargs, meta)

# pyre-ignore[16]: `None` has no attribute `node`
input_shape = args[0].node.meta["val"].shape
output_shape = meta["val"].shape
if not _squeezable(input_shape):

if not self.should_squeeze(op, input_shape):
return super().call_operator(op, args, kwargs, meta)

def _squeezable(shape: List[int]) -> bool:
return len(shape) > 2 and 1 in shape

# squeeze input tensor
squeeze_shape = list(input_shape)
while _squeezable(squeeze_shape):
Expand Down
Loading