Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm backend: Add pre-push checks for op tests #9899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Arm backend: Add pre-push checks for op tests #9899

wants to merge 1 commit into from

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Apr 4, 2025 •
edited by pytorch-bot bot
Loading

  • Check that @SkipIfNoCorstone is not used
  • Check that @expectedFailureOnFVP is not used
  • Check that unittest.TestCase is not used
  • Check that on_fvp suffix is not used
  • Check that op and target is parsed from the test name

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@AdrianLundell
Arm backend: Add pre-push checks for op tests
2b944ec 
- Check that @SkipIfNoCorstone is not used
- Check that @expectedFailureOnFVP is not used
- Check that unittest.TestCase is not used
- Check that on_fvp suffix is not used
- Check that op and target is parsed from the test name

Change-Id: I7c25783ff3b5a75fe7ea96c7aeca3008813ee277
Signed-off-by: Adrian Lundell <[email protected]>
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Apr 4, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9899

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 2b944ec with merge base 4717459 (image):

NEW FAILURE - The following job has failed:

  • pull / unittest-arm / linux-job (gh)
    RuntimeError: Command docker exec -t 642197c16a1aef4af17f3a5d283dc37a86967a7cc428b56411ea8938d7419f84 /exec failed with exit code 1

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2025
digantdesai
digantdesai approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianLundell @digantdesai @facebook-github-bot