Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intel macOS check; update docs #9865

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

keyprocedure
Copy link
Contributor

@keyprocedure keyprocedure commented Apr 3, 2025

Summary

Fixes #9772

Adds a platform check in install_requirements.py to exit early on Intel-based macOS systems since they're no longer supported by PyTorch/ExecuTorch. Also updates documentation.

References:

Test plan

  • macOS (ARM64): Verified install proceeds normally
  • macOS (Intel): Verified install_requirements script exits with ERROR: ExecuTorch does not support Intel-based macOS platforms. message

Copy link

pytorch-bot bot commented Apr 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9865

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2b067cf with merge base 0844c38 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2025
@keyprocedure
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@keyprocedure
Copy link
Contributor Author

@pytorchbot unlabel "topic: not user facing"

Copy link

pytorch-bot bot commented Apr 3, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'unlabel' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick', 'close')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@keyprocedure
Copy link
Contributor Author

@pytorchbot label "module: build/install"

@pytorch-bot pytorch-bot bot added the module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch label Apr 3, 2025
@keyprocedure keyprocedure marked this pull request as ready for review April 3, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return "platform not supported" when using PyTorch on intel-based Macbooks
2 participants