-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for hpu device #2595
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all my comments were resolved. It still needs to be reviewed by a maintainer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you paste a snapshot of the results?
@jeromean here is the result for both train and eval modetest_BERT_pytorch_train_hpu (main.TestBenchmark) ... ok **Ran 101 tests in 860.358s FAILED (errors=5, skipped=24)** ========================================================================================================== EVAL MODE FAILED (errors=7, skipped=9)** |
@jeromean can you review and approve the change |
@xuzhao9 , I wonder if you could help review this PR? |
Adding a new device support named 'hpu'