Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pip install calls in scripts to use uv. And messages to reference current executable #13597

Merged
merged 6 commits into from
Mar 27, 2025
Merged

Update pip install calls in scripts to use uv. And messages to reference current executable #13597

merged 6 commits into from
Mar 27, 2025

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Mar 7, 2025 •
edited
Loading

This doesn't force working with a virtual environment nor using a specific name for your venv (uv pip and uv run --active will reuse your activated environment)

Note I didn't touch python/python3 in docs this PR.
I'm also leaving GitHub jobs to a separate self-contained PR.

@Avasam Avasam added the project: infrastructure typeshed build, test, documentation, or distribution related label Mar 7, 2025
@Avasam Avasam mentioned this pull request Mar 8, 2025
Merged
Akuli
Akuli reviewed Mar 9, 2025
View reviewed changes
@Avasam Avasam changed the title Use uv pip in scripts and docs Update pip install calls in scripts to use uv or reference current executable Mar 9, 2025
Akuli
Akuli reviewed Mar 10, 2025
View reviewed changes
Akuli
Akuli reviewed Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We should probably mention this to avoid assuming uv in later changes to this script.

@Avasam
Copy link
Collaborator Author

Avasam commented Mar 27, 2025 •
edited
Loading

Post-merge this undoes the changes in #13706 and unconditionally uses uv for that script. Since anything past the installation of requirements-tests.txt we can assume uv will be available. And uv pip respects the currently activated venv.

CC @srittau and @donBarbos

@Avasam Avasam changed the title Update pip install calls in scripts to use uv or reference current executable Update pip install calls in scripts to use uv. And messages to reference current executable Mar 27, 2025
@srittau srittau merged commit 11929de into python:main Mar 27, 2025
58 checks passed
@Avasam Avasam deleted the use-uv-pip-in-scripts branch March 27, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@srittau srittau srittau approved these changes

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
project: infrastructure typeshed build, test, documentation, or distribution related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Avasam @srittau @Akuli @AlexWaygood