Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json.scanner.NUMBER_RE #13405

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Add json.scanner.NUMBER_RE #13405

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15f0f82
Add json.scanner.NUMBER_RE
tjkuson Jan 18, 2025
54fbac6
Update stdlib/json/scanner.pyi
tjkuson Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stdlib/json/scanner.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
from _json import make_scanner as make_scanner
from re import Pattern
from typing import Final

__all__ = ["make_scanner"]

NUMBER_RE: Final[Pattern[str]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NUMBER_RE: Final[Pattern[str]]
NUMBER_RE: Final[Pattern[str]] # undocumented

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't include that comment to match undocumented patterns in stdlib/json/encoder.pyi. Should I update those as well (be it in this PR or in a follow-up)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's good to mark all of these undocumented attributes. I'll merge this one now, feel free to send another PR marking undocumented things elsewhere.

Loading