-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127146: Fix Emscripten test suite when run with -uall #132092
base: main
Are you sure you want to change the base?
Conversation
Emscripten large file support works fine and is required for `testZip64LargeFile` to work. And skip more stack overflows
Can confirm the test suite now completes for me without crashing. I'm seeing 2 test failures at runtime on the Buildbot machine (using emscripten 4.0.6, running
and
Are you seeing those failures as well? |
Nope. Did you run it on this specific commit? The sysconfigdata failure I was seeing in the fall but @FFY00 made some changes that made it go away for me a couple months ago. Is the |
I will double check everything in my setup and rerun the tests. |
I can reproduce the |
I sometimes get:
But I cannot reproduce the |
I've run it twice with 3d49b34, and once with f36c496, and it has failed all three times. Updating to f36c496 has resolved the sysconfig issue, though. I have tried to reproduce the failure locally, but the hotel wifi I'm on is currently blocking downloads from GitHub 🙄 . I'll be at a different hotel in about 12 hours, so I can try again there. |
I've finally got a chance to test this locally, and I'm seeing the same problem (running on macOS). |
You okay to skip it and investigate later? |
I'm not wild about merging an open ended TODO; and given it will be about a week before I'll have a chance to focus on getting the buildbot in place, and this is literally the last piece before we have a clean test run, I'd rather do at least a preliminary investigation so we've got an idea how deep this hole goes. |
Sounds good. I just wish I could reproduce it. I'll try cleaning everything and rebuild again. |
Emscripten large file support works fine and is required for
testZip64LargeFile
to work.And skip more stack overflows
@freakboy3742