GH-103180: Set a timeout for every job in GitHub Actions #130375
Conversation
AA-Turner
requested review from
brandtbucher,
savannahostrowski,
ezio-melotti and
hugovk
as code owners
AA-Turner
changed the title
| @@ -137,6 +137,7 @@ jobs: | |||
| name: Free-Threaded (Debug) | |||
| needs: interpreter | |||
| runs-on: ubuntu-24.04 | |||
| timeout-minutes: 90 | |||
There was a problem hiding this comment.
Note 90 minutes used here rather than 60, for consistency with the other two JIT jobs.
AA-Turner
changed the title
|
I am not familiar with .yml, but definitely approve of the goal. |
hugovk
added
needs backport to 3.12
|
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to |
|
Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to |
|
@AA-Turner Please could you do the backports? |
|
I think we need the other backports merged first, then Miss Islington might work? A |
|
Please could you check #130367? Then let's retry. |
…pythonGH-130375) (cherry picked from commit d0a1e5c) Co-authored-by: Adam Turner <[email protected]>
|
GH-130431 is a backport of this pull request to the 3.13 branch. |
…pythonGH-130375) (cherry picked from commit d0a1e5c) Co-authored-by: Adam Turner <[email protected]>
|
GH-130432 is a backport of this pull request to the 3.12 branch. |
Backports (eventually....) done |
As a half-workaround to GHA job hangs, this sets an explicit timeout on every job, meaning that it can be restarted after a sane period, rather than the default 6 hour (360 minute) allowance. This has a marginal benefit of freeing up CI resource quicker on such hangs, as we fail far sooner.
I've also standardised job names to use hyphens instead of the current mix of underscores and dashes, and made the order of inputs more consistent in a couple of cases.
Most notably, this means that if the required 'Check whether the needed jobs succeeded or failed' job hangs/fails, it can be restarted in 5 minutes, rather than pushing an empty commit or closing/reopening and triggering the full test suite again.
A
See also: