Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Show translation source' to docs sidebar #130355

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Feb 20, 2025

@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Feb 20, 2025
Co-authored-by: Hugo van Kemenade <[email protected]>
@m-aciek
Copy link
Contributor

m-aciek commented Feb 20, 2025

I suggest to change the PR title to make it clear it's about the docs.

@StanFromIreland StanFromIreland changed the title Add 'Show translation source' to sidebar Add 'Show translation source' to docs sidebar Feb 20, 2025
@AA-Turner
Copy link
Member

I'm -1 on this. .po files are not very friendly for reading by people, and are designed as a translation format mapping source to translated strings. I similarly see little value in 'show source', as the reStructuredText source is so unlikely to be useful (some themes have replaced this with a link to the source on GitHub, but I'm still unconvinced).

A

@hugovk
Copy link
Member

hugovk commented Feb 20, 2025

I often use "show source" when I want to check, well, the source, for example if there's something amiss.

If there's a translation that's missing or fixing, is the .po file the file that needs editing? If so, this would make it easy to click through and make a quick PR.

@StanFromIreland
Copy link
Contributor Author

Hugo already mentioned the main point.

Another thing is the current „show source” button is useless in the translations as it is the English source.

This will contributions as it is easy to find where the files are as the repo is not linked anywhere else in the docs!

And also, Adam, you don’t have to worry about seeing it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants