Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-130213: Check availability of Intel SIMD types #130332

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmroot
Copy link
Contributor

@jmroot jmroot commented Feb 20, 2025

blake2module.c includes headers that use SIMD typedefs if an SIMD implementation will be built, but must not itself be compiled with the -m options that enable SIMD instructions. However, the *mmintrin headers are not always usable to get those typedefs if the corresponding -m option is not used.

Copy link
Contributor

@msprotz msprotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as discussed and matches my understanding of the problem. Thank you!

jmroot and others added 2 commits February 21, 2025 08:20
blake2module.c includes headers that use SIMD typedefs if an SIMD
implementation will be built, but must not itself be compiled with the
-m options that enable SIMD instructions. However, the *mmintrin
headers are not always usable to get those typedefs if the
corresponding -m option is not used.
@jmroot jmroot force-pushed the check-simd-headers branch from fafe746 to 2897e64 Compare February 20, 2025 21:22
@jmroot
Copy link
Contributor Author

jmroot commented Feb 20, 2025

The force push was just to fix a typo in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants