Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-130296: Avoid stack transients in 3 instructions. #130310

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

GH-130296: Avoid stack transients in 3 instructions. #130310

wants to merge 5 commits into from
+469 −730

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Feb 19, 2025 •
edited by bedevere-app bot
Loading

This PR:

  • Enhances the code generators to properly handle micro-ops with two cache entries
  • Combines _GUARD_GLOBALS_VERSION_PUSH_KEYS and _LOAD_GLOBAL_MODULE_FROM_KEYS into _LOAD_GLOBAL_MODULE
  • Combines _GUARD_BUILTINS_VERSION_PUSH_KEYS and _LOAD_GLOBAL_BUILTINS_FROM_KEYS into _LOAD_GLOBAL_BUILTINS
  • Combines _CHECK_ATTR_MODULE_PUSH_KEYS and _LOAD_ATTR_MODULE_FROM_KEYS into _LOAD_ATTR_MODULE

@bedevere-app bedevere-app bot mentioned this pull request Feb 19, 2025
Open
@markshannon markshannon marked this pull request as ready for review February 20, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markshannon