gh-128991: Release the enter frame reference within bdb callback #128992
+37
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaogaotiantian
added
needs backport to 3.12
|
In theory, this is not a bug fix and should not be backported. However, this is required for #125549. Also it would be nice if we don't hold the frame reference for too long in previous versions. |
iritkatriel
approved these changes
Jan 18, 2025
|
Thanks @gaogaotiantian for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @gaogaotiantian, I could not cleanly backport this to |
|
Sorry, @gaogaotiantian, I could not cleanly backport this to |
|
GH-129002 is a backport of this pull request to the 3.13 branch. |
gaogaotiantian
added a commit
to gaogaotiantian/cpython
that referenced
this pull request
Jan 18, 2025
…callback (pythonGH-128992) * Release the enter frame reference within bdb callback * 📜🤖 Added by blurb_it. --------- (cherry picked from commit 61b35f7) Co-authored-by: Tian Gao <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
|
GH-129003 is a backport of this pull request to the 3.12 branch. |
gaogaotiantian
added a commit
that referenced
this pull request
Jan 18, 2025
gaogaotiantian
added a commit
that referenced
this pull request
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a context manager to release the enter frame reference, instead of doing it in
continue.