-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128923: Use zero to indicate unassigned unique id #128925
Conversation
In the free threading build, the per thread reference counting uses a unique id for some objects to index into the local reference count table. Use 0 instead of -1 to indicate that the id is not assigned. This avoids bugs where zero-initialized heap type objects look like they have a unique id assigned.
Co-authored-by: T. Wouters <[email protected]>
|
|
|
Re: the buildbot failures, they're happening because the newly added heaptype inherits from object and does not have the |
#128951 should fix the buildbot failures. (This wasn't picked up by GHA because we apparently have no GHA that runs the tests in a single process/sequentially.) |
In the free threading build, the per thread reference counting uses a unique id for some objects to index into the local reference count table. Use 0 instead of -1 to indicate that the id is not assigned. This avoids bugs where zero-initialized heap type objects look like they have a unique id assigned.