Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use xyzservices instead of templates #1827

Merged
merged 5 commits into from
Nov 7, 2023
Merged

use xyzservices instead of templates #1827

merged 5 commits into from
Nov 7, 2023

Conversation

martinfleis
Copy link
Collaborator

This removes built-in tile management with the template files and adds xyzservices as a hard dependency that now manages all tiles. It is fully backwards compatible with all the benefits of a large library in xyzservices and flexibility of query_name, allowing custom characters and cases in the input. E.g. all of these will work

"CartoDB Positron"
"cartodbpositron"
"cartodb-positron"
"carto db/positron"
"CARTO_DB_POSITRON"
"CartoDB.Positron"

@martinfleis martinfleis mentioned this pull request Nov 6, 2023
Open
10 tasks
ocefpaf
ocefpaf approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Conengmo
Conengmo reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very happy with this change! I added a couple comments, but nothing stopping this.

folium/raster_layers.py Outdated Show resolved Hide resolved
folium/raster_layers.py Show resolved Hide resolved
folium/raster_layers.py Show resolved Hide resolved
@martinfleis
Copy link
Collaborator Author

I think that this should be ready now.

Conengmo
Conengmo approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@martinfleis martinfleis merged commit 84459ba into python-visualization:main Nov 7, 2023
12 checks passed
@martinfleis martinfleis deleted the xyzservices branch November 7, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conengmo Conengmo Conengmo approved these changes

@ocefpaf ocefpaf ocefpaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinfleis @ocefpaf @Conengmo