Skip to content

Initial refactoring #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: spike
Choose a base branch
from
Open

Initial refactoring #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
441bc96
Add refactoring note
nasedil May 22, 2017
8a272a1
Fix failing test
nasedil Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,16 @@ python-opc
VERSION: 0.0.1d (first development release)


STATUS (as of October 20 2013)
STATUS (as of May 22 2017)
==============================

May 2017 update: In process of refactoring and integrating changes from the python-pptx library.

First development release. Under active development.

WARNING:`spike` branch is SUBJECT TO FULL REBASING at any time. You probably
don't want to base a pull request on it without asking first.


Vision
======

Expand Down
4 changes: 2 additions & 2 deletions tests/test_package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,9 @@ def it_constructs_custom_part_type_for_registered_content_types(self):
PartFactory.part_type_for[CT.WML_DOCUMENT_MAIN] = CustomPartClass
part = PartFactory(partname, CT.WML_DOCUMENT_MAIN, blob)
# verify -----------------------
CustomPartClass.assert_called_once_with(partname,
CustomPartClass.load.assert_called_once_with(partname,
CT.WML_DOCUMENT_MAIN, blob)
assert part is CustomPartClass.return_value
assert part is CustomPartClass.load.return_value


class Describe_Relationship(object):
Expand Down