Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RedisSettings explanation in main_demo.py #422

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

RamonGiovane
Copy link
Contributor

@RamonGiovane RamonGiovane commented Dec 6, 2023

Related to #279 (comment)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #422 (305a003) into main (94cd878) will increase coverage by 2.12%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

❗ Current head 305a003 differs from pull request most recent head 253867e. Consider uploading reports for the commit 253867e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   96.27%   98.40%   +2.12%     
==========================================
  Files          11       11              
  Lines        1074     1063      -11     
  Branches      209      200       -9     
==========================================
+ Hits         1034     1046      +12     
+ Misses         19        8      -11     
+ Partials       21        9      -12     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9731f54...253867e. Read the comment docs.

@samuelcolvin samuelcolvin enabled auto-merge (squash) April 1, 2024 14:43
@samuelcolvin
Copy link
Member

Looks good, thanks so much.

@samuelcolvin samuelcolvin changed the title Improve RedisSettings explanation in main_demo.py Improve RedisSettings explanation in main_demo.py Apr 1, 2024
@samuelcolvin samuelcolvin merged commit 33e4760 into python-arq:main Apr 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants