Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.8 support, add 3.13 #572

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Drop Python 3.8 support, add 3.13 #572

merged 4 commits into from
Dec 11, 2024

Conversation

nicoddemus
Copy link
Member

No description provided.

@nicoddemus
Copy link
Member Author

Wait a bit until actions/setup-python publishes official 3.13 packages.

@nicoddemus nicoddemus closed this Oct 10, 2024
@nicoddemus nicoddemus reopened this Oct 10, 2024
@The-Compiler
Copy link
Member

@nicoddemus looks like this dropped off your radar? Looking at #107 the CI seems pretty broken currently.

@nicoddemus
Copy link
Member Author

Thanks for the ping, indeed I had completely forgotten about this one.

Rebased, let's see.

@nicoddemus
Copy link
Member Author

I don't think PySide2 is still supported, the last release was in 2022, and of course there is no more releases for more recent Python versions.

Perhaps we should drop official support for it as well?

The-Compiler
The-Compiler previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking things up again, looks great!

@The-Compiler
Copy link
Member

I don't think PySide2 is still supported, the last release was in 2022, and of course there is no more releases for more recent Python versions.

Perhaps we should drop official support for it as well?

I suppose we could, though not sure how much there is to gain if we still keep Qt5 (via PyQt5) around? https://pypi.org/project/PyQt5/#history seems alive enough to keep it IMHO.

nicoddemus and others added 4 commits December 11, 2024 09:17
@nicoddemus
Drop Python 3.8 support, add 3.13
0bf9f13
@nicoddemus
Add dependabot.yml for automatic update of GitHub Actions
f225334
@nicoddemus
Fix test_catch_exceptions_in_virtual_methods for pyside6
cbe077c 
The latest release seems to have changed the message:

```
ValueError: Error calling Python override of QObject::event(): mistakes were made'
```
@nicoddemus
Skip some pyside2 builds
28223c0 
Not available yet on Python 3.13 on all platforms.
Not available on MacOS.
@nicoddemus
Copy link
Member Author

nicoddemus commented Dec 11, 2024 •
edited
Loading

I personally have interest in keeping PyQt5 compatibility because that's what we still use at ESSS, plus it is still maintained as you said.

I will open a PR removing pyside2 and we can evaluate if it is worth it or not.

@nicoddemus nicoddemus merged commit f2bbc28 into master Dec 11, 2024
53 checks passed
@nicoddemus nicoddemus deleted the py38-py313 branch December 11, 2024 12:25
@nicoddemus nicoddemus mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Compiler The-Compiler The-Compiler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoddemus @The-Compiler