feat: Configuration option for setting default loop_scope for tests #1035
+141
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Novakov
force-pushed
the
config-option-default-test-loop-scope
branch
4 times, most recently
from
cb06135 to
5272cc4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
+ Coverage 91.13% 91.27% +0.13%
==========================================
Files 2 2
Lines 564 573 +9
Branches 74 75 +1
==========================================
+ Hits 514 523 +9
Misses 30 30
Partials 20 20 ☔ View full report in Codecov by Sentry. |
seifertm
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Thank you! I really like how you changed _get_marked_loop_scope and how you used functions to keep the code readable.
Can you please add an entry to docs/reference/changelog.rst where you link to #793 ?
Assume that this PR bumps the minor version and set the date to UNRELEASED.
Novakov
force-pushed
the
config-option-default-test-loop-scope
branch
2 times, most recently
from
787a67d to
aa2339d
Compare
New configuration option, asyncio_default_test_loop_scope, provides default value for loop_scope argument of asyncio marker. This can be used to use the same event loop in auto mode without need to use modifyitems hook. Test functions can still override loop_scope by using asyncio marker.
Novakov
force-pushed
the
config-option-default-test-loop-scope
branch
from
aa2339d to
6c3a941
Compare
|
Thanks for kind words. I've rebased this branch and applied modifications you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New configuration option,
asyncio_default_test_loop_scope, provides default value for loop_scope argument ofasynciomarker. This can be used to use the same event loop in auto mode without need to usemodifyitemshook.Test functions can still override
loop_scopeby usingasynciomarker.Implements #793