Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect handling of dirfd in os.symlink #969

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Fix incorrect handling of dirfd in os.symlink #969

merged 1 commit into from
Mar 10, 2024

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Mar 10, 2024 •
edited
Loading

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing

@mrbean-bremen
Fix incorrect handling of dirfd in os.symlink
fa4f228 
- also removed check for supported dirfd where not used
- changed dirfd tests to run both in the fake and real OS
- fixed pytest-dev#968
@mrbean-bremen mrbean-bremen merged commit 190390f into pytest-dev:main Mar 10, 2024
65 checks passed
@mrbean-bremen mrbean-bremen deleted the dirfd branch March 10, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patched os.symlink mishandles directory descriptors
1 participant
@mrbean-bremen