-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added partial support for pandas to work with pyfakefs #532
Added partial support for pandas to work with pyfakefs #532
Conversation
mrbean-bremen
commented
Jun 13, 2020
- support for read_csv and read_excel (with the default module)
- see Patch known libraries where possible #531
- support for read_csv and read_excel (with the default module) - see pytest-dev#531
@jmcgeheeiv - please have a look. I will check if I can add tests/fixes for more read functions in pandas, but that will not change much. |
- adapted documentation for pandas support - added test for pandas.read_table()
41fa87a
to
f459e90
Compare
- no tests added (would be a bit complicated), has been tested in production code
84486df
to
4286167
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, very sophisticated.
Note the typesetting for an em dash contains no spaces:
I thought I saw a ghost--but it was you.
You could use the real—
em dash HTML entity—but that's too much trouble here. Stick with two minus signs.
Semicolons and em dash are advanced writing and you are using them correctly. Well done.
problems. It may be removed or replaced by a more fine-grained argument in | ||
future releases. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete extra line.
Thanks--learned something new! For me the missing spaces look a bit awkward, but that may be a matter of what I am used to (in German, there are spaces around the em dash, as far as I know). I usually don't think about punktuation at all.
I will add you changesr and merge. I will wait a bit (in case new bugs come in, or I think of something else to do...), and probably make another another release (4.1), if that is ok with you. |
5df81aa
to
adbfbcc
Compare
- added test for writing excel file
adbfbcc
to
073d019
Compare
Now tell that punk daughter of yours that your English punctuation has the
seal of approval from a native speaker.
Yes, when I started using the em dash without spaces it did look strange to
me. Check the German usage--you may be surprised!
…On Sun, Jun 14, 2020 at 3:36 AM mrbean-bremen ***@***.***> wrote:
Note the typesetting for an em dash contains no spaces
Thanks--learned something new! For me the missing spaces look a bit
awkward, but that may be a matter of what I am used to (in German, there
are spaces around the em dash, as far as I know). I usually don't think
about punktuation at all.
I also found this in the punktuation guide
<https://www.thepunctuationguide.com/em-dash.html>:
The em dash is typically used without spaces on either side, and that is
the style used in this guide. Most newspapers, however, set the em dash off
with a single space on each side.
I will add you changesr and merge. I will wait a bit (in case new bugs
come in, or I think of something else to do...), and probably make another
another release (4.1), if that is ok with you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#532 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4MWAPNHWXXUGJOJYQTMHTRWSRYTANCNFSM4N44OZSA>
.
|