Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added partial support for pandas to work with pyfakefs #532

Merged
merged 4 commits into from
Jun 14, 2020

Conversation

mrbean-bremen
Copy link
Member

- support for read_csv and read_excel (with the default module)
- see pytest-dev#531
@mrbean-bremen
Copy link
Member Author

mrbean-bremen commented Jun 13, 2020

@jmcgeheeiv - please have a look. I will check if I can add tests/fixes for more read functions in pandas, but that will not change much.

- adapted documentation for pandas support
- added test for pandas.read_table()
- no tests added (would be a bit complicated),
  has been tested in production code
Copy link
Contributor

@jmcgeheeiv jmcgeheeiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, very sophisticated.

Note the typesetting for an em dash contains no spaces:

I thought I saw a ghost--but it was you.
You could use the real — em dash HTML entity—but that's too much trouble here. Stick with two minus signs.

Semicolons and em dash are advanced writing and you are using them correctly. Well done.

problems. It may be removed or replaced by a more fine-grained argument in
future releases.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete extra line.

@mrbean-bremen
Copy link
Member Author

Note the typesetting for an em dash contains no spaces

Thanks--learned something new! For me the missing spaces look a bit awkward, but that may be a matter of what I am used to (in German, there are spaces around the em dash, as far as I know). I usually don't think about punktuation at all.
I also found this in the punktuation guide:

The em dash is typically used without spaces on either side, and that is the style used in this guide. Most newspapers, however, set the em dash off with a single space on each side.

I will add you changesr and merge. I will wait a bit (in case new bugs come in, or I think of something else to do...), and probably make another another release (4.1), if that is ok with you.

- added test for writing excel file
@mrbean-bremen mrbean-bremen merged commit f7a8f6d into pytest-dev:master Jun 14, 2020
@mrbean-bremen mrbean-bremen deleted the pandas-support branch June 14, 2020 11:13
@jmcgeheeiv
Copy link
Contributor

jmcgeheeiv commented Jun 14, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants