Skip to content

Only construct DynamicPatcher if necessary #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2017
Merged

Only construct DynamicPatcher if necessary #336

merged 1 commit into from
Dec 24, 2017
+3 −4

Conversation

absolutelyNoWarranty
Copy link
Contributor

@absolutelyNoWarranty absolutelyNoWarranty commented Dec 24, 2017 •
edited
Loading

Solves issue #334, which is caused by DynamicPatcher deleting stuff from sys.modules during its initialization.

@absolutelyNoWarranty
Only construct DynamicPatcher if necessary

Verified

This commit was signed with the committer’s verified signature.
Evalir evalir
SSH Key Fingerprint: ij9tIAPh3zJ2wDU7vAK5CU+0QuasLrNVjKZ6HQeh3Bo
Verified
Learn about vigilant mode
00150f8
mrbean-bremen
mrbean-bremen approved these changes Dec 24, 2017
View reviewed changes
Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Xmas fix! This looks good - was obviously a mistake to create the patcher if it is not neesed.
I plan to have another go at the dynamic patcher some time later anyway to make it really usable.

@mrbean-bremen mrbean-bremen merged commit 09632f9 into pytest-dev:master Dec 24, 2017
@mrbean-bremen mrbean-bremen mentioned this pull request Dec 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbean-bremen mrbean-bremen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@absolutelyNoWarranty @mrbean-bremen