Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable subworkflow #36

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

ekatef
Copy link
Member

@ekatef ekatef commented Mar 31, 2024

Closes #35, #20 and (hopefully) #32

Changes proposed in this Pull Request

Copy-pasted changes from PyPSA-Earth-Sec intended to add an option for switching-off the sub-workflows replacing them by a direct path definitions.

Tested on mac, seems to work properly and make life much easier. @davide-f thanks a lot for the proposed solution!

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to the main environment at PyPSA-Earth repository
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@ekatef
Copy link
Member Author

ekatef commented Mar 31, 2024

As a comment: for some reason, Snakemake linter is not happy with the changes complaining about missed keyword at the function definition for pypsaearth and usage for create_country_list. (So the commits have been possible only with --no-verify. Sorry for that!) However, both points seem to be perfectly valid approaches for Snakemake, as follows from the examples in Advanced Usage, so I'd rather say that the linter is not perfectly correct.

@davide-f
Copy link
Member

davide-f commented Apr 2, 2024

That is weird, agree. Let's merge anyway :D

@davide-f davide-f merged commit dcc89d7 into pypsa-meets-earth:main Apr 2, 2024
1 of 2 checks passed
@ekatef
Copy link
Member Author

ekatef commented Apr 2, 2024

That is weird, agree. Let's merge anyway :D

Thanks a lot for the idea of the fix and for merging!! Great to have the workflow running 🛫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to disable the subworkflow by config file
2 participants