Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone removal of eggs discovery when using the importlib.metadata backend to 26.3 #13315

Closed
wants to merge 1 commit into from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Apr 5, 2025

We postpone removal of eggs support to 26.3 (which is the earliest version when we may remove Python 3.10 support), and stop warning for Python < 3.11 (because we don't plan to remove pkg_resources for these Python versions while pip supports them).

Towards #12330

See also #13185 (comment)

We postpone removal of eggs support to 26.3 (which is the earliest version when we may remove Python 3.10 support), and stop warning for Python < 3.11 (because we don't plan to remove pkg_resources for these Python versions while pip supports them).
@sbidoul sbidoul added this to the 25.1 milestone Apr 5, 2025
@sbidoul sbidoul added skip news Does not need a NEWS file entry (eg: trivial changes) and removed skip news Does not need a NEWS file entry (eg: trivial changes) labels Apr 5, 2025
@sbidoul
Copy link
Member Author

sbidoul commented Apr 5, 2025

I'm not sure this is worth a news entry, as this only postpones a deprecation that was already announced.

@sbidoul sbidoul changed the title Postpone removal of eggs support Postpone removal of eggs support to 26.3 Apr 5, 2025
@sbidoul sbidoul added the type: deprecation Related to deprecation / removal. label Apr 5, 2025
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call to suppress the deprecation warning on Python 3.9, 3.10, and 3.11 since they will always use pkg_resources until pip is unsupported on those versions.

@sbidoul sbidoul marked this pull request as draft April 6, 2025 09:15
@sbidoul
Copy link
Member Author

sbidoul commented Apr 6, 2025

I'm setting this back to draft following a discovery I just made: #12330 (comment)

@sbidoul sbidoul changed the title Postpone removal of eggs support to 26.3 Postpone removal of eggs discovery when using the importlib.metadata backend to 26.3 Apr 6, 2025
@sbidoul
Copy link
Member Author

sbidoul commented Apr 6, 2025

Following the problems discovered in #12330 (comment) and following comment, I close this one and propose to remove that code path in 25.1 as announced.

@sbidoul sbidoul closed this Apr 6, 2025
@sbidoul sbidoul deleted the postpone-eggs-support-removal branch April 6, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: deprecation Related to deprecation / removal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants