Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test packaging flow on Windows #13184

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Conversation

ichard26
Copy link
Member

Most of pip's maintainers use non-Windows environments, so it's easy for our tooling to regress on Windows. Let's avoid that for our release flow.

In addition, remove the dependency on the packaging job by the test jobs. The packaging job rarely fails so we aren't saving any CI resources by failing early if the packaging job fails.

The only reason to gate the tests jobs on the packaging step would be to reduce CI failure noise when pip's packaging is broken, resulting most of the tests jobs also failing. By gating the test jobs on the packaging job, only the packaging failure would be visible, making easier to figure out the root problem. I don't think this happens much in practice though.

@ichard26 ichard26 added type: maintenance Related to Development and Maintenance Processes skip news Does not need a NEWS file entry (eg: trivial changes) labels Jan 26, 2025
Most of pip's maintainers use non-Windows environments, so it's easy for
our tooling to regress on Windows. Let's avoid that for our release
flow.

In addition, remove the dependency on the packaging job by the test
jobs. The packaging job rarely fails so we aren't saving any CI
resources by failing early if the packaging job fails.
@ichard26 ichard26 marked this pull request as ready for review January 27, 2025 00:13
@ichard26
Copy link
Member Author

ichard26 commented Feb 16, 2025

On second thought, I'm not sure how much value this adds given this won't catch subtle failures,1 but we do have a custom build script now so perhaps that's enough surface area to warrant additional testing. cc @pfmoore

Footnotes

  1. Unless we compare the artifacts across platforms, which would be better done when we fully support deterministic builds of pip (which is blocked on setuptools).

@ichard26
Copy link
Member Author

If no one objects in the next few days, I'll merge this. This probably has limited benefit, but if it avoids release-day chaos because of Windows (even merely due to a silly and trivially easy to fix mistake), it's worth it IMO.

@ichard26 ichard26 merged commit 7eb71fa into pypa:main Mar 31, 2025
29 checks passed
@ichard26 ichard26 deleted the test-packaging-ci branch March 31, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants