RTT host-to-target communication #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of RTT host-to-target communication with minimal terminal features in the "rtt" subcommand.
|
This pull request introduces 1 alert and fixes 1 when merging 8a67290 into c90d7bc - view on LGTM.com new alerts:
fixed alerts:
|
flit
requested changes
Dec 1, 2021
There was a problem hiding this comment.
Since this change is pretty significant, would you mind adding your copyright to the rtt_cmd.py header comment?
Aside from that, just please fix the unused local variable warning from LGTM.
If you feel like it, type annotations would be nice but aren't strictly required yet.
Closed
flit
reviewed
Dec 2, 2021
|
This pull request fixes 1 alert when merging db1553f into bc54e81 - view on LGTM.com fixed alerts:
|
flit
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of RTT host-to-target communication for pyOCD's
rttsubcommand.stdinshort commands for the targetstdinis read one character at a time, in a non-blocking fashion. Characters are echoed to the terminal and accumulated in a buffer until we see a CR of LF. At that point, if there is sufficient space in the RTT down-buffer (host-to-target), the buffer is copied character-by-character to the RTT ring buffer.stdin, allowing the user to make corrections before hitting CR/LF. ESC terminates the session.rtt_cmd.py, including the addition of a class (copied from here) for cross-platform, non-blocking read of 1 character from stdin.