Use shell=False for Popen on Windows

[michaelosthege]

Description

I'm having hard times creating new environments with working compiler dependencies.

My debugging attempts show that shell=False could fix this, however this observation contradicts the comments next to that line.
Further testing may be required. Tested on another machine.

I also removed an old workaround for Python 2..

Related Issue

Hints?

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pytensor--1324.org.readthedocs.build/en/1324/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (f1514eb) to head (c78cef1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1324   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files         203      203           
  Lines       48863    48863           
  Branches     8695     8695           
=======================================
  Hits        40093    40093           
  Misses       6619     6619           
  Partials     2151     2151           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[michaelosthege]

@Armavica you also worked on these components - what do you think about shell=False? Does it work on your machine?

[Armavica]

I will have a look this weekend or next week

[michaelosthege]

I will have a look this weekend or next week

@Armavica did you already get a chance?

[Armavica]

I don't think I worked specifically on this besides cosmetic changes, and I never tried to install PyTensor on Windows.
However, I think if we can make things work with shell=False it's probably for the best. Have you tried without the list to string conversion that follows, that is supposed to be only needed for shell=True?

[michaelosthege]

Have you tried without the list to string conversion that follows

Without the list to string conversion already the first test failed.