Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also undeprecate optparse #10215

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Also undeprecate optparse #10215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02bebc6
also undeprecate optparse
aaronliu0130 Feb 1, 2025
eb5d7da
add to news fragment
aaronliu0130 Feb 1, 2025
bb28bf1
fix tests
aaronliu0130 Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/whatsnew/fragments/10211.false_positive
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Remove `getopt` from the list of deprecated modules.
Remove `getopt` and `optparse` from the list of deprecated modules.

Closes #10211
1 change: 0 additions & 1 deletion pylint/checkers/imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@

DEPRECATED_MODULES = {
(0, 0, 0): {"tkinter.tix", "fpectl"},
(3, 2, 0): {"optparse"},
(3, 3, 0): {"xml.etree.cElementTree"},
(3, 4, 0): {"imp"},
(3, 5, 0): {"formatter"},
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/d/deprecated/deprecated_module_py3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Test deprecated modules."""
# pylint: disable=unused-import
# pylint: disable=unused-import, import-error

import optparse # [deprecated-module]
import formatter # [deprecated-module]
2 changes: 1 addition & 1 deletion tests/functional/d/deprecated/deprecated_module_py3.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
deprecated-module:4:0:4:15::Deprecated module 'optparse':UNDEFINED
deprecated-module:4:0:4:16::Deprecated module 'formatter':UNDEFINED
2 changes: 1 addition & 1 deletion tests/functional/d/deprecated/deprecated_module_py36.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Test deprecated modules from Python 3.6."""
# pylint: disable=unused-import,import-error

import optparse # [deprecated-module]
import formatter # [deprecated-module]
2 changes: 1 addition & 1 deletion tests/functional/d/deprecated/deprecated_module_py36.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
deprecated-module:4:0:4:15::Deprecated module 'optparse':UNDEFINED
deprecated-module:4:0:4:16::Deprecated module 'formatter':UNDEFINED
4 changes: 2 additions & 2 deletions tests/functional/d/deprecated/deprecated_relative_import/dot_relative_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# pylint: disable=import-error, missing-module-docstring, unused-import

# from import of stdlib optparse which should yield deprecated-module error
from optparse import OptionParser # [deprecated-module]
from formatter import NullFormatter # [deprecated-module]
# from import of module internal optparse module inside this package.
# This should not yield deprecated-module error
from .optparse import Bar
from .formatter import Bar
2 changes: 1 addition & 1 deletion tests/functional/d/deprecated/deprecated_relative_import/dot_relative_import.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
deprecated-module:4:0:4:33::Deprecated module 'optparse':UNDEFINED
deprecated-module:4:0:4:35::Deprecated module 'formatter':UNDEFINED
6 changes: 3 additions & 3 deletions .../functional/d/deprecated/deprecated_relative_import/subpackage/dot_dot_relative_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# pylint: disable=import-error, unused-import, missing-module-docstring
# pylint: disable=import-error, missing-module-docstring, unused-import

# from import of stdlib optparse which should yield deprecated-module error
from optparse import OptionParser # [deprecated-module]
from formatter import NullFormatter # [deprecated-module]
# from import of module internal optparse module inside this package.
# This should not yield deprecated-module error
from ..optparse import Bar
from .formatter import Bar
2 changes: 1 addition & 1 deletion ...functional/d/deprecated/deprecated_relative_import/subpackage/dot_dot_relative_import.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
deprecated-module:4:0:4:33::Deprecated module 'optparse':UNDEFINED
deprecated-module:4:0:4:35::Deprecated module 'formatter':UNDEFINED
1 change: 0 additions & 1 deletion tests/functional/n/no/no_member_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Tests for no-member on imported modules"""
# pylint: disable=import-outside-toplevel, pointless-statement, missing-function-docstring
# pylint: disable=deprecated-module


def test_no_member_in_getattr():
Expand Down
6 changes: 3 additions & 3 deletions tests/functional/n/no/no_member_imports.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
no-member:10:4:10:28:test_no_member_in_getattr:Module 'math' has no 'THIS_does_not_EXIST' member:INFERENCE
no-member:25:4:25:33:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'THIS_does_not_EXIST' member:INFERENCE
no-member:44:4:44:27:test_ignored_classes_no_recursive_pattern:Module 'sys' has no 'THIS_does_not_EXIST' member:INFERENCE
no-member:9:4:9:28:test_no_member_in_getattr:Module 'math' has no 'THIS_does_not_EXIST' member:INFERENCE
no-member:24:4:24:33:test_ignored_modules_invalid_pattern:Module 'xml.etree' has no 'THIS_does_not_EXIST' member:INFERENCE
no-member:43:4:43:27:test_ignored_classes_no_recursive_pattern:Module 'sys' has no 'THIS_does_not_EXIST' member:INFERENCE
Loading