Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] droplabel when combined with other selectors does not exclude labels #1444

Conversation

samukweku
Copy link
Collaborator

PR Description

Please describe the changes proposed in the pull request:

  • DropLabel now excludes labels when combined with other selectors

This PR resolves #1408 .

Please tag maintainers to review.

samuel.oranyeli added 2 commits February 4, 2025 22:01
@ericmjl
Copy link
Member

ericmjl commented Feb 4, 2025

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @samukweku!

@samukweku samukweku merged commit 85b7af3 into dev Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DropLabel when combined with other selectors does not exclude labels
2 participants