Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TXT2KG w/ hotpot_qa.pyGraph Retrieval Example and tech_qa.py HybridRAG e2e workflow example #9992

Open
wants to merge 390 commits into
base: master
Choose a base branch
from

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented Jan 29, 2025

@puririshi98
Copy link
Contributor Author

@rusty1s @akihironitta this is mostly ready for review, except i need to cleanup for the CI linters, but any early reviews would help getting this merged once those cleanups are done.

@puririshi98 puririshi98 changed the title Draft: TXT2KG w/ hotpot_qa.pyGraph Retrieval Example and tech_qa.py HybridRAG e2e workflow example TXT2KG w/ hotpot_qa.pyGraph Retrieval Example and tech_qa.py HybridRAG e2e workflow example Feb 12, 2025
# We use NIMs since most PyG users may not be able to run a 70B+ model
from openai import OpenAI
global CLIENT
CLIENT = OpenAI(base_url="https://integrate.api.nvidia.com/v1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to expose base_url through argparse

Copy link
Contributor Author

@puririshi98 puririshi98 Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree, could you submit a PR into my branch that does this for txt2kg and llmjudge and tests it out with some openAI model(s) and icnlude the results in the PR description. would be cool to see how nemotron70b compares to using any openAI model(s) you choose. i dont have an openai api account set up so this would be great help and good benchmark. Zack will also be submitting PRs to my branch so we will all just be co-authors of this super PR which i'll push through after a few PRs from zack and this one from you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants