Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim pydata-google-auth package and add tests #3

Merged
merged 5 commits into from
Sep 7, 2018
Merged

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Sep 7, 2018

This is the initial version of the proposed pydata-google-auth package (to be used by pandas-gbq and ibis). It includes two methods:

  • pydata_google_auth.default()
    • A function that does the same as pandas-gbq does auth currently. Tries google.auth.default() and then falls back to user credentials.
  • pydata_google_auth.get_user_credentials()

I drop try_credentials(), as it makes less sense when this module might be used for other APIs besides BigQuery. Plus there were problems with try_credentials() even for pandas-gbq (googleapis/python-bigquery-pandas#202, googleapis/python-bigquery-pandas#198).

FYI @max-sixty @cpcloud

@tswast tswast changed the title Trim pydata_google_auth package and add tests Trim pydata-google-auth package and add tests Sep 7, 2018
@tswast tswast merged commit 7ce7f3f into master Sep 7, 2018
@tswast tswast deleted the auth-tests branch September 7, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant