Export resource_class_map and fix bug in Role.add_user() #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for exporting resource_class_map is to allow an external module to support additional resource types without the need to edit resources.py (I had edited it previously but this became a maintenance nightmare). The Role.add_user() bug is (I hope) an obvious one: the groups argument was ignored.
adehad
approved these changes
May 19, 2021
There was a problem hiding this comment.
Verified with the API documentation that group is the right parameter. Happy for this to get merged.
Cloud:
- Posting to the
/rest/api/2/project/{projectIdOrKey}/role/{id}endpoint 
Server/Data Center
- Posting to the
/rest/api/2/project/{projectIdOrKey}/role/{id}endpoint 
|
I think you are quoting two different endpoints?
(I've only ever used the server endpoint.) |
|
Ah yes. My mistake. I've updated the original approving comment. |
ssbarnea
approved these changes
May 24, 2021
svermeulen
pushed a commit
to svermeulen/jira
that referenced
this pull request
Oct 31, 2021
…1047) The reason for exporting resource_class_map is to allow an external module to support additional resource types without the need to edit resources.py (I had edited it previously but this became a maintenance nightmare). The Role.add_user() bug is (I hope) an obvious one: the groups argument was ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for exporting resource_class_map is to allow an external module to support additional resource types without the need to edit resources.py (I had edited it previously but this became a maintenance nightmare).
The Role.add_user() bug is (I hope) an obvious one: the groups argument was ignored.
(This is a duplicate of PR #1002.)