Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix angle bug #16

Closed
wants to merge 54 commits into from
Closed

Fix angle bug #16

wants to merge 54 commits into from

Conversation

EmilyBourne
Copy link
Member

The difference between 2 angles needs to take into account the behaviour of values close to theta=0. This was not done correctly leading to infinite loops on implicit tests.

Eg:

q1 = 15 * pi / 16
q2 = pi/16
diff = 14 pi / 16 # should equal -pi/8

dominikbell and others added 30 commits July 18, 2022 10:21
@dominikbell
added missing import statements in examples/advection_visualisation
52ef4ea
@dominikbell
fixed some more dependency issues
5248a7a
@dominikbell
Merge pull request #1 from dominikbell/fix-imports-1
f9d20f3 
Fix imports
@dominikbell
changed first set of type declarators
fef1b1c
@dominikbell
added types decorators; indicated todo for doc
0a15f19
@dominikbell
even more type declarators
660f90d
@dominikbell
Merge pull request #2 from dominikbell/add-pyccel-types
7dbc5c7 
Add pyccel types
@dominikbell
added removal of lock and pycc files
997ed88
@dominikbell
fixed some incorrect type declarators, formatted documents for better…
8fd5771 
… readability
@dominikbell
Merge pull request #3 from dominikbell/fixes-to-type-declarators
f080940 
Fixes to type declarators
@dominikbell
highest level has been formatted
6628f06
@dominikbell
formatted all files in /advection
9b522e5
@dominikbell
formatted files in /diagnostics
5ad84a6
@dominikbell
formatted files in examples, initialisation
1668286
@dominikbell
formatted files in /model
6fbeba6
@dominikbell
formatted files in /poisson
52ed7d5
@dominikbell
formatted all files inside /splines
8a8a29a
@dominikbell
formatted files in /tools
70c0918
@dominikbell
formatted files in utilities
3f0881d
@dominikbell
Merge pull request #5 from dominikbell/format-all-files
932345a 
Format all files
@dominikbell
put everything inside a main() function
8cdb2a2
@dominikbell
added type converter for pyccel
03068e1
@dominikbell
changed scipy.csc.csc_matrix to scipy.csc_matrix (to avoid deprecatio…
ab6f9c1 
…n warning)
@dominikbell
replaced some while loops with modulo operator
cc5680d
@dominikbell
smaller format corrections, removed unnecessary statements connected …
ed81691 
…to modulo operator
@dominikbell
Merge pull request #6 from dominikbell/format-full-sim
561de79 
Format full_simulation and smaller corrections
@EmilyBourne
Create symbolic link
daded79
@dominikbell
Merge pull request #8 from dominikbell/missing_folder
024cf5e 
Create symbolic link
@EmilyBourne
Add missing symbolic link
2d4c730
@dominikbell
Merge pull request #9 from dominikbell/missing_folder
8842611 
Add missing symbolic link
dominikbell and others added 24 commits July 26, 2022 17:45
@dominikbell
symbolic link formatting
1ddaca4
@dominikbell
readded pure and stack_array declarators (allow_negative_index not du…
ae38ed5 
…e to a bug in pyccel)
@dominikbell
corrected pythran comments (removed space)
4ee0cf5
@dominikbell
removed tilde from comments
72ec774
@dominikbell
reduced size of example setup in order to run it on mobile computers
883c6d7
@dominikbell
added type float statement for implicit step of poloidal advection, s…
7d3b1a0 
…maller corrections
@dominikbell
Merge pull request #10 from dominikbell/readd-pure-declarator
8175b74 
Readd pure declarator
@EmilyBourne
Import dependencies after modifiying path
d1336ce
@EmilyBourne
Remove useless links
d6a348d
@EmilyBourne
Test numba
fad30d0
@EmilyBourne
Remove passing test
38b1215
@dominikbell
Merge pull request #11 from dominikbell/fix_numba
42f0a13 
Fix numba
@dominikbell
replaced %= operations by = and %
ba3d809
@dominikbell
added brackets for correct modulo operation
6890e58
@dominikbell
Merge pull request #12 from dominikbell/fix-mod-eq
0e00289 
replaced %= operations by = and %
@EmilyBourne
Add pep8 test
a2e4369
@dominikbell
fixed some format problems in order to pass codacy test
346ca8b
@dominikbell
Merge pull request #14 from dominikbell/codacy-pass
47da3e0 
fixed some format problems in order to pass codacy test
@EmilyBourne
Pep8 changes
f8e988a
@EmilyBourne
Modify makefile to allow removal of sys fiddle
b6712a7
@dominikbell
removed unused variable in favour of more ugly code for codacy
2cbcd73
@dominikbell
Merge pull request #15 from dominikbell/codacy-fix-2
7534774 
removed unused variable in favour of more ugly code for codacy
@dominikbell
Merge pull request #13 from dominikbell/pep8_test
56cc03a 
Add pep8 test
@EmilyBourne
Correct angle bug
aae6adc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilyBourne @dominikbell