Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh: Tests content - about, write tests, types of tests #136

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Dec 20, 2023

This PR is a simplified version of the now draft #104 . I've implemented all of the comments in that pr here. And only include the landing page, and two pages from the guide focused on new content around tests.

This will be easier to merge given it's a more focused PR.
Let's plan to have this PR merged by next week which is December 28 2023!


@lwasser lwasser changed the title New: tests content - about, write tests, types of tests [Review round 2- dec 28 merge] tests content - about, write tests, types of tests Dec 20, 2023
@lwasser
Copy link
Member Author

lwasser commented Dec 28, 2023

this has had a full round of review. And no real comments this round (possibly because of the holidays). I am going to merge this as planned BUT we can always revisit / edit as needed!!

@lwasser lwasser changed the title [Review round 2- dec 28 merge] tests content - about, write tests, types of tests Enh: Tests content - about, write tests, types of tests Dec 28, 2023
@lwasser lwasser merged commit 6c16020 into pyOpenSci:main Dec 28, 2023
@lwasser lwasser deleted the tests-only-fin branch December 28, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant