Enh: add hatch_vcs for versioning #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
something is odd because i see the tags in the history but there are no tags listed here in the repo. |
ofek
reviewed
Dec 20, 2023
src/pyosmeta/_version.py
Outdated
| @@ -0,0 +1,17 @@ | |||
| # file generated by setuptools_scm | |||
| # don't change, don't track in version control | |||
There was a problem hiding this comment.
Thank you so so much, @ofek !! i just fixed this and pushed it up. i really appreciate your help.
|
@all-contributors please add @ofek for code, review |
|
I've put up a pull request to add @ofek! 🎉 |
|
This is now ready for review! everything is working as it should locally now 🚀 and i've cleaned up the pyproject.toml file thanks to @ofek suggestion above! ✨ |
2 tasks
ofek
approved these changes
Dec 24, 2023
Co-authored-by: Ofek Lev <[email protected]>
|
pre-commit.ci autofix |
|
thank you again @ofek im going to merge this now!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a start at vcs based versioning. i opened a question around how to setup the correct template here i'm sure that i just don't understand how to help it understand how we are versioning things. right now it's grabbing version. 0.1 even tho we have tag 0.2
addresses in part #82