Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: headers should use webp and remove the overlay (for accessibility and load) #591

Merged
merged 9 commits into from
Mar 19, 2025

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Mar 18, 2025

This is a start at ensuring we use webp in our headers and removing the overlay

@lwasser lwasser marked this pull request as draft March 18, 2025 00:45
@lwasser
Copy link
Member Author

lwasser commented Mar 18, 2025

This is almost done but then will need to fix existing header images so the text is legible and the overlay is in the image itself.

Then a few tweaks to the hero font padding, etc. and we are done 🚀

@lwasser lwasser mentioned this pull request Mar 19, 2025
1 task
@lwasser lwasser changed the title fix: headers redo fix: headers should use webp and remove the overlay (for accessibility and load) Mar 19, 2025
@lwasser lwasser marked this pull request as ready for review March 19, 2025 20:42
@lwasser lwasser marked this pull request as draft March 19, 2025 20:44
@lwasser
Copy link
Member Author

lwasser commented Mar 19, 2025

something weird is happening with the blog listing. debugging - not ready to merge yet

@lwasser lwasser marked this pull request as ready for review March 19, 2025 21:00
@lwasser
Copy link
Member Author

lwasser commented Mar 19, 2025

fixed! merging now.

@lwasser lwasser merged commit 8a717ab into pyOpenSci:main Mar 19, 2025
4 checks passed
@lwasser lwasser deleted the fix-headers branch March 19, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant